fix: Remove usage of lodash/isArray and React.StatelessComponent#2539
Open
lucas-koehler wants to merge 2 commits intomasterfrom
Open
fix: Remove usage of lodash/isArray and React.StatelessComponent#2539lucas-koehler wants to merge 2 commits intomasterfrom
lucas-koehler wants to merge 2 commits intomasterfrom
Conversation
✅ Deploy Preview for jsonforms-examples ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
sdirix
requested changes
Feb 11, 2026
Member
sdirix
left a comment
sdirix
left a comment
There was a problem hiding this comment.
Thanks for the changes!
The packages/vanilla-renderers/src/cells/BooleanCell.tsx also uses the StatelessComponent. Should be fixed too.
The StatelessRenderer which is now deprecated is still used in tests, i.e. packages/react/test/renderers/JsonForms.test.tsx and packages/material-renderers/test/renderers/MaterialArrayControl.test.tsx. Should we remove the usage there?
lucas-koehler
force-pushed
the
issues/2538-ts-errors
branch
from
16abcf7 to
5fcd38a
Compare
Contributor
Author
|
@sdirix Thanks for the valuable feedback ❤️ . That makes total sense. I did both and integrated it in the previous commit so we can keep both commits in this PR separately on merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #2538